[WIP] add language processing to ldpath service #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
force-pushed
the
ldpath_languages
branch
from
65c759c
to
65c3dca
Compare
elrayle
changed the title
elrayle
force-pushed
the
ldpath_languages
branch
2 times, most recently
from
830b75f
to
b6da716
Compare
NOTE: This commit references a branch in ldpath. It needs to be removed when PR #18 is merged into the ldpath gem.
elrayle
force-pushed
the
ldpath_languages
branch
from
b6da716
to
fce0947
Compare
|
Apologies for any annoyance, but this is to please document and confirm that samvera-labs/ldpath#18 is actually a blocking PR for merging these proposed changes. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Pending change in ldpath gem
Fixes #288; Partially addresses #289
The ldpath_service was not honoring requests for languages. With this change, if languages are passed into the ldpath_program method and the property being requested has a language marker in it, the program will create a request for each language and for all untagged literals.
The ldpath_execute method will recombine these values into language tagged RDF::Literals.
Without this, the language processing in QA is unable to properly sort multiple values within a single language.