Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test switching to google search box #231

Merged
merged 2 commits into from
May 11, 2018
Merged

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Apr 3, 2018

Replaced existing search box with a google search box. Refers to #109

TODO:

  • Needs some CSS work to position search box.
    screen shot 2018-04-13 at 6 00 26 pm
  • Need to handle baseurl in dev mode (currently commented out in _includes/google_search.html)
  • is currently based on my ND google account. Need to decide where to set up the custom search (see https://cse.google.com/cse/)
  • there are several configuration options in custom search. I used the overlay option but we could change this.
  • Also has an issue with the paths behind the popped up search results... seems to not be finding some js and css. If you use the X to close the search results, you get the unformatted page)
    screen shot 2018-04-13 at 5 59 10 pm
[2018-04-13 18:03:55] ERROR `/search/css/syntax.css' not found.
[2018-04-13 18:03:55] ERROR `/search/css/modern-business.css' not found.
[2018-04-13 18:03:55] ERROR `/search/css/theme-blue.css' not found.
[2018-04-13 18:03:55] ERROR `/search/js/jquery.navgoco.min.js' not found.
[2018-04-13 18:03:55] ERROR `/search/css/customstyles.css' not found.
[2018-04-13 18:03:55] ERROR `/search/js/toc.js' not found.
[2018-04-13 18:03:55] ERROR `/search/css/lavish-bootstrap.css' not found.
[2018-04-13 18:03:55] ERROR `/search/js/customscripts.js' not found.
[2018-04-13 18:03:55] ERROR `/search/images/company_logo.png' not found.
[2018-04-13 18:03:55] ERROR `/search/js/jquery.navgoco.min.js' not found.
[2018-04-13 18:03:55] ERROR `/search/js/toc.js' not found.
[2018-04-13 18:03:55] ERROR `/search/js/customscripts.js' not found.

@laritakr laritakr added this to In Progress in Documentation Working Group Apr 3, 2018
@laritakr laritakr self-assigned this Apr 3, 2018
@laritakr laritakr added the R & D label Apr 17, 2018
@afred afred removed this from In Progress in Documentation Working Group Apr 17, 2018
@laritakr laritakr changed the title [WIP] Test switching to google search box Test switching to google search box May 11, 2018
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laritakr laritakr merged commit 0967790 into master May 11, 2018
@laritakr laritakr deleted the test-google-search-box branch May 11, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants