Begin patterns documentation including overview and presenter pattern #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laritakr
requested changes
May 25, 2018
| * `@presenter` should be the only instance variable accessed in the view. | ||
| * `@presenter` can be passed as `presenter` to partials rendered from the primary view. | ||
| * The same presenter can be shared by multiple views and partials. | ||
| * Presenters can be used with any kind of view. Although, they are not used with new/edit forms. The Forms pattern performs a similar role for the forms. |
There was a problem hiding this comment.
Grammar is awkward here (line 22). The second partial sentence should be combined with the first.
laritakr
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to include the A-Z Index page if it has been updated
Then make sure that commit of pages/atoz.md is in this PR