Ensure correct column width for overly long words. #340
Conversation
Ensure correct column width in case of overly long words.
| @@ -181,6 +181,7 @@ table th[class*="col-"] { | |||
|
|
|||
| table td:first-child { | |||
| width: 150px; | |||
There was a problem hiding this comment.
I wonder what was the reason to fix the first column for all tables in this style? My only guess was the tags pages, e.g. http://samvera.github.io/tag_getting_started.html
However the fixed column width breaks the view on mobile devices. I suggest to remove this line, too.
There was a problem hiding this comment.
@jmfrenzel sorry for the delay in response to this. Can you give us a before and/or after screen shot of the behavior you're describing? We tried looking at what you are describing and we didn't see anything jump out at us.
There was a problem hiding this comment.
Working on _i18n support for the samvera documentation theme (see https://github.com/jmfrenzel/documentation-theme-jekyll-multiple_language_pop) and at the same time on a local site for research data management at RUB using a fixed table width one creates problems in case breaking long words (as we have in German).
For now it would be sufficient to get the idea behind introducing the fixed table width as in the original theme https://github.com/tomjoht/documentation-theme-jekyll/ it wasn't used.
In our dev deploy we use the latter config. Compare the English https://jekyll.rd.ruhr-uni-bochum.de/tag_getting_started.html and the German versions https://jekyll.rd.ruhr-uni-bochum.de/de/tag_getting_started.html
|
Hi @jmfrenzel, do you have CLAs on file? (Sorry, I know it's legal rigmarole, but we need them on file to accept contributions). |
|
I do.
On Sep 18, 2018 7:42 PM, "Andrew Myers" <notifications@github.com> wrote:
Hi @jmfrenzel <https://github.com/jmfrenzel>, do you have an CLAs
<http://samvera.github.io/formalities.html> on file? (Sorry, I know it's
legal rigmarole, but we need them on file to accept contributions).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#340 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AdLcguIHeca9R8mR3mTq4D-LDp4VxHizks5ucTCUgaJpZM4WfIFm>
.
|
Ensure correct column width in case of overly long words.
Be sure to include the A-Z Index page if it has been updated
Then make sure that commit of pages/atoz.md is in this PR