-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.0 RC1 #628
2.0.0 RC1 #628
Conversation
@awead @Cam156 I wonder if you can take a look at this? |
@tpendragon do you want me to run CHO against this branch or do you need benchmarks? |
@awead If you can get Cho running on it, that'd be awesome. It'd probably be easier to go to 1.3 first - a bunch of deprecation warnings make the upgrade much easier. |
https://gist.github.com/tpendragon/81ce9c47a381b6ff864ff760312064e5 My benchmarks. Everything seems to be within the standard deviation - no changes one way or the other. |
@tpendragon 1.4 works fine. But, when I try this RC branch, I'm getting: > Valkyrie::Types::Set.member
NoMethodError: undefined method `member' for #<Dry::Types::Default:0x007fe4a8aa1ee8>
from /Users/agw13/.asdf/installs/ruby/2.4.1/lib/ruby/gems/2.4.0/gems/dry-types-0.13.4/lib/dry/types/decorator.rb:77:in `method_missing' To put that in context, we're doing this: https://github.com/psu-libraries/cho/blob/master/app/cho/work/with_use_type.rb#L27 |
@tpendragon Ok, unstuck after changing |
a3da11e
to
6cf6cd0
Compare
6cf6cd0
to
beaa697
Compare
Update dry-struct, remove ActiveFedora as a dependency, and remove deprecations.