Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 RC1 #628

Merged
merged 5 commits into from
Jan 29, 2019
Merged

2.0.0 RC1 #628

merged 5 commits into from
Jan 29, 2019

Conversation

tpendragon
Copy link
Collaborator

Update dry-struct, remove ActiveFedora as a dependency, and remove deprecations.

@tpendragon tpendragon changed the title 2.0 RC1 [WIP] 2.0 RC1 Jan 4, 2019
@tpendragon
Copy link
Collaborator Author

@awead @Cam156 I wonder if you can take a look at this?
@ojlyytinen I don't know if you're still benchmarking things, but it'd be interesting to compare this branch.

@awead
Copy link
Contributor

awead commented Jan 4, 2019

@tpendragon do you want me to run CHO against this branch or do you need benchmarks?

@tpendragon
Copy link
Collaborator Author

tpendragon commented Jan 4, 2019

@tpendragon do you want me to run CHO against this branch or do you need benchmarks?

@awead If you can get Cho running on it, that'd be awesome. It'd probably be easier to go to 1.3 first - a bunch of deprecation warnings make the upgrade much easier.

@tpendragon
Copy link
Collaborator Author

https://gist.github.com/tpendragon/81ce9c47a381b6ff864ff760312064e5 My benchmarks. Everything seems to be within the standard deviation - no changes one way or the other.

@awead
Copy link
Contributor

awead commented Jan 9, 2019

@tpendragon 1.4 works fine. But, when I try this RC branch, I'm getting:

> Valkyrie::Types::Set.member
NoMethodError: undefined method `member' for #<Dry::Types::Default:0x007fe4a8aa1ee8>
from /Users/agw13/.asdf/installs/ruby/2.4.1/lib/ruby/gems/2.4.0/gems/dry-types-0.13.4/lib/dry/types/decorator.rb:77:in `method_missing'

To put that in context, we're doing this: https://github.com/psu-libraries/cho/blob/master/app/cho/work/with_use_type.rb#L27

@awead
Copy link
Contributor

awead commented Jan 9, 2019

@tpendragon Ok, unstuck after changing member to of. Apparently, there was a deprecation warning previously for this method, which I do actually remember addressing, but for some reason it wasn't catching this line. I can run the test suite, and it's got some errors. I'll see what I can find out.

@escowles escowles changed the title [WIP] 2.0 RC1 2.0.0 RC1 Jan 29, 2019
@escowles escowles merged commit 43cd98f into master Jan 29, 2019
@tpendragon tpendragon mentioned this pull request Jan 29, 2019
@jeremyf jeremyf deleted the update_dry_struct_again branch January 31, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants