Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start testing ActiveRecord 6.0 #758

Merged
merged 1 commit into from Sep 4, 2019
Merged

Start testing ActiveRecord 6.0 #758

merged 1 commit into from Sep 4, 2019

Conversation

tpendragon
Copy link
Collaborator

With the release of Rails 6.0, we should ensure that Valkyrie is
compatible.

@tpendragon
Start testing ActiveRecord 6.0
8b25c9d 
With the release of Rails 6.0, we should ensure that Valkyrie is
compatible.
cjcolvar
cjcolvar approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

botimer
botimer approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@botimer botimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with appraisal, but everything looks consistent. 🚢

@tpendragon tpendragon merged commit e8a30b9 into master Sep 4, 2019
@tpendragon tpendragon deleted the rails_6_testing branch September 4, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botimer botimer botimer approved these changes

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpendragon @botimer @cjcolvar