Update docs, and fix bugs in user form and Flickr import

docs/contacts.rst

@@ -0,0 +1,35 @@
+.. _contacts:
+
+Contacts and Users
+==================
+
+Contacts in Twyne represent :ref:`post <posts>` Authors, and can also be made into site Users.
+When a new Twyne site is installed an initial Contact and matching User are created,
+with full admin rights for everything.
+
+All Contacts have a name, homepage URL, and two descriptions (one public, one private).
+Contacts that are also site users have, in addition, a username and email address,
+and a set of user groups that they belong to.
+
+Creating a Contact
+------------------
+
+There are various ways to create a new Contact:
+
+* Go to 'Contacts' in the main menu, and then the 'New contact' link.
+* When editing a post, or in the upload form, the author field is free-text.
+  If an unknown author name is used, a new Contact will be created.
+* Registering a new user account will result in a matching Contact being created.
+
+User Authentication
+-------------------
+
+All users are identified by their username, and authenticate with a password.
+Two-factor authentication is also enabled by default,
+requiring the use of an TOTP app.
+
+If a user loses their 2FA credentials, their account can be reset by using the reset command, e.g.::
+
+    ./bin/console twyne:reset-2fa --username alice
+
+This will force then to re-register a 2FA device.

docs/index.rst

@@ -28,6 +28,7 @@ we will endevour to fix up the manual to make it clearer about that topic.
    install
    config
    settings
+   contacts
    posts
    tags
    syndications

docs/posts.rst

@@ -40,7 +40,7 @@ Author
 
 A Post must have an author (even if that author is the ever-prolific "anon.").
 A site's default author can be set with the ``APP_MAIN_CONTACT`` environment variable,
-which is a reference to the ID of whichever Contact should be the default
+which is a reference to the ID of whichever :ref:`Contact <contacts>` should be the default
 (usually this is the first user, which is created at install-time).
 
 Title

src/Command/TwyneFlickrCommand.php

@@ -328,7 +328,7 @@ public function importOnePhoto(array $photo)
             'latitude' => $photo['latitude'],
             'longitude' => $photo['longitude'],
             'view_group' => $viewGroup,
-            'tags' => join('; ', $tags),
+            'tags' => $tags,
             'new_syndication' => ['url' => $photoUrl, 'label' => 'Flickr'],
         ];
         $this->postRepository->saveFromRequest($post, new Request([], $requestParams), $uploadedFile);

templates/contact/form.html.twig

@@ -53,7 +53,7 @@
             </p>
             <p>
                 Is <abbr title="Two-factor authentication">2FA</abbr> configured?
-                {% if contact.user.twoFASecret %}&check;{% else %}&cross;{% endif %}
+                {% if contact.user and contact.user.twoFASecret %}&check;{% else %}&cross;{% endif %}
             </p>
             <p><strong>Groups:</strong></p>
             <p class="fields">