Disable robots on test environment (#80) (#81)

Dockerfile

@@ -9,8 +9,6 @@ RUN npm ci && \
     rm -rf ./.cache ./src/assets package-lock.json && \
     find ./src -type f -name '*.spec.js' -delete
 
-ENV NODE_ENV=production
-
 EXPOSE 3000
 
 CMD ["npm", "start"]

package.json

@@ -16,7 +16,7 @@
     "eslint": "eslint '**/*.js' --ignore-pattern public/",
     "eslint:report": "npm run eslint -- -f json -o reports/eslint.xml",
     "stylelint": "stylelint 'src/assets/**/*.scss'",
-    "test": "NODE_ENV=test && jest .*.spec.js --verbose",
+    "test": "export NODE_ENV=jest && jest .*.spec.js --verbose",
     "test:watch": "npm run test -- --watch",
     "test:coverage": "npm run test -- --coverage"
   },

src/app.js

@@ -4,16 +4,21 @@ const morgan = require('morgan');
 const compression = require('compression');
 const minifyHTML = require('express-minify-html');
 
+const { version } = require('../package.json');
+
 const routes = require('./routes');
 
+const environment = process.env.NODE_ENV || 'production';
+
 const app = express();
 
 /* istanbul ignore next */
-if (process.env.NODE_ENV !== 'test') {
-  app.use(helmet());
+if (process.env.NODE_ENV !== 'jest') {
   app.use(morgan('combined'));
 }
 
+app.use(helmet());
+
 app.use(compression());
 app.set('view engine', 'pug');
 app.set('views', './src/views');
@@ -31,7 +36,20 @@ app.use('/public', express.static('./src/public'));
 
 app.use(routes);
 
-app.get('/robots.txt', (req, res) => res.type('text/plain').send('User-agent: *\nDisallow:'));
+app.get('/robots.txt', (req, res) => {
+  let robots = 'User-agent: *\nDisallow:';
+  if (environment === 'test') {
+    robots = 'User-agent: *\nDisallow: /';
+  }
+
+  res.type('text/plain').send(robots);
+});
+
+app.get('/version', (req, res) => res.json({
+  version,
+  environment,
+  viewCache: app.get('view cache'),
+}));
 
 app.get('/status', (req, res) => res.sendStatus(200));
 

src/app.spec.js

@@ -2,12 +2,23 @@ const request = require('supertest');
 
 const app = require('./app');
 
+const packageFile = require('../package.json');
+
 it('gets robots', async () => {
   const response = await request(app).get('/robots.txt');
 
   expect(response.text).toBe('User-agent: *\nDisallow:');
 });
 
+it('gets version', async () => {
+  const response = await request(app).get('/version');
+
+  expect(response.body).toStrictEqual({
+    version: packageFile.version,
+    environment: 'jest',
+  });
+});
+
 it('gets health check', async () => {
   const response = await request(app).get('/status');