Support cross compilation / CompileKind::target inference #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think using |
|
I think in this case it's safe to ignore any failed tests as they were written for the initial project, which was a hack I made for some linux gamedev that I was working. |
|
However for now will merge this pull request to close #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect
env:OUT_DIRto determineCompileKind, injecting target into the output path if found.Originally, I had it working with get_project_root (see #3 discussion), but when copying that code over I noticed that it will cause the tests to fail since the tests aren't recreating a full cargo build environment.
Not sure if that's the direction @prenwyn wants to go or not, so what I've changed it to be best effort to keep the tests happy. The ideal solution in my opinion would be to revamp the testing to run
cargo buildon sample project(s) to test the various setups.