Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #343

Merged
merged 16 commits into from Nov 17, 2017
Merged

Update dependencies #343

merged 16 commits into from Nov 17, 2017

Conversation

san650
Copy link
Owner

@san650 san650 commented Nov 17, 2017

Update all dependencies marked as red or yellow in david-dm.org

This PR also removes the blueprint introduced in #274 which is hard to maintain. It's better suited to be its own ember-addon.

Also fixes #320

@san650 san650 force-pushed the update-dependencies branch 3 times, most recently from b0ab6c1 to b746544 Compare November 17, 2017 21:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.063% when pulling bac7831 on update-dependencies into 48454ad on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.063% when pulling f157f3e on update-dependencies into 48454ad on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.063% when pulling ca7142e on update-dependencies into 48454ad on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.063% when pulling 642fafb on update-dependencies into 48454ad on master.

scenarios: [
{
name: 'ember-1.12',
name: 'ember-lts-2.4',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to drop 1.12. I think we definitely support it

Copy link
Owner Author

@san650 san650 Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost sure the addon still can be installed with ember-1.12, but its really hard to make our addons tests compatible with those old versions.

ember 1.12 is more than two years old which is a long time in js terms, I think we did a good job keeping it for so long, but it's time to move on 😃 .

Unless someone feels too strong about it, I think it's best to start doing some changes in the code to make it easier to maintain. That's why I'm removing a whole blueprint in this same PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this blueprint looked massive. I hope nobody actively use a component-test blueprint 😆

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, it's a candidate to be its own addon.

#319 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.063% when pulling de3d4dd on update-dependencies into 48454ad on master.

@san650 san650 merged commit d2da6b1 into master Nov 17, 2017
@san650 san650 deleted the update-dependencies branch November 17, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test failing with ember@canary in local development
3 participants