New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #343
Update dependencies #343
Conversation
b0ab6c1
to
b746544
Compare
bac7831
to
8dcbea3
Compare
8dcbea3
to
f157f3e
Compare
scenarios: [ | ||
{ | ||
name: 'ember-1.12', | ||
name: 'ember-lts-2.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to drop 1.12. I think we definitely support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm almost sure the addon still can be installed with ember-1.12, but its really hard to make our addons tests compatible with those old versions.
ember 1.12 is more than two years old which is a long time in js terms, I think we did a good job keeping it for so long, but it's time to move on 😃 .
Unless someone feels too strong about it, I think it's best to start doing some changes in the code to make it easier to maintain. That's why I'm removing a whole blueprint in this same PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this blueprint looked massive. I hope nobody actively use a component-test
blueprint 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally, it's a candidate to be its own addon.
Update all dependencies marked as red or yellow in david-dm.org
This PR also removes the blueprint introduced in #274 which is hard to maintain. It's better suited to be its own ember-addon.
Also fixes #320