-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generators #35
Generators #35
Conversation
import PageObject from '../../page-object'; | ||
|
||
function checked(selector /*, options */) { | ||
return $(selector).prop('checked'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't assume $
is global, maybe we can import Ember
import Ember from 'ember';
let $ = Ember.$;
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It would be great to have the list of available blueprints in the README.md Maybe something like: The addon includes the following blueprints
And then leave the current |
return $(selector).prop('checked'); | ||
} | ||
|
||
export default PageObject.customHelper(checked); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use the name provided by the user as the name of the function:
function <%= camelizedModuleName %>(selector/*, options*/) {
return ...;
}
export default PageObject.customHelper(<%= camelizedModuleName %>);
What do you think?
http://www.ember-cli.com/extending/#template-variables-aka-locals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@juanazam ping |
@san650 pong |
Also avoid Redefinition of '$'
Closes #32