New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ember-cli@3.5 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like some changes in the travis config re-enabled double CI build. |
ro0gr
force-pushed
the
ember-3.5
branch
3 times, most recently
from
December 15, 2018 09:48
1d400a8
to
f5ff081
Compare
It contains npm ignores for unconventional paths, mostly related to jekyll stuff
Also added it to ignore files
A combo of ember-qunit-codemod and ember-page-object-codemod were used
Good work @ro0gr 👏 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates internals to use ember/ember-cli of v3.5.
There is also some cleanup included, which is related to extending ignore files rules with assets produced by
jekyll
, etc..The issue with upgrade is that with the new blueprint for some of ember-try scenarios we have
jquery-integration
feature set to off which makes old-style global testing helpers non-working.Going to keep the following strategy:
moduleFor
tests ifEmber.$
is not availablemoduleForComponent
torendering
tests