Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember-cli@3.5 #439

Merged
merged 14 commits into from Dec 17, 2018
Merged

Upgrade to ember-cli@3.5 #439

merged 14 commits into from Dec 17, 2018

Conversation

ro0gr
Copy link
Collaborator

@ro0gr ro0gr commented Dec 11, 2018

Updates internals to use ember/ember-cli of v3.5.

There is also some cleanup included, which is related to extending ignore files rules with assets produced by jekyll, etc..

The issue with upgrade is that with the new blueprint for some of ember-try scenarios we have jquery-integration feature set to off which makes old-style global testing helpers non-working.

Going to keep the following strategy:

  • skip moduleFor tests if Ember.$ is not available
  • re-write some of old tests from moduleForComponent to rendering tests
  • re-enable jquery by default. This would allow to keep all the tests in the dev mode

@ro0gr
Copy link
Collaborator Author

ro0gr commented Dec 13, 2018

Seems like some changes in the travis config re-enabled double CI build. travis-ci/push was disabled before this PR, will investiagate.

@coveralls
Copy link

coveralls commented Dec 13, 2018

Coverage Status

Coverage increased (+0.1%) to 98.642% when pulling 738eae7 on ember-3.5 into 01bb5a5 on master.

@ro0gr ro0gr force-pushed the ember-3.5 branch 3 times, most recently from 1d400a8 to f5ff081 Compare December 15, 2018 09:48
@ro0gr ro0gr changed the title [wip] ember-cli 3.5 Upgrade to ember-cli@3.5 Dec 15, 2018
@ro0gr ro0gr merged commit af7acea into master Dec 17, 2018
@san650 san650 deleted the ember-3.5 branch December 17, 2018 21:26
@san650
Copy link
Owner

san650 commented Dec 17, 2018

Good work @ro0gr 👏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants