Deprecate setContext #448
Merged
Deprecate setContext #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
commented
Mar 1, 2019
ro0gr
commented
Mar 1, 2019
ro0gr
force-pushed
the
setContext-free
branch
2 times, most recently
from
9636abd
to
68039e9
Compare
ro0gr
commented
Oct 26, 2019
ro0gr
changed the title
ro0gr
commented
Oct 26, 2019
| } | ||
|
|
||
| if (!contextName) { | ||
| throw new Error('Can not detect test type. Please make sure you use the latest version of "@ember/test-helpers".'); |
There was a problem hiding this comment.
unfortunatelly, in added test, there are some require.unsee conflicts with https://github.com/san650/ember-cli-page-object/blob/master/tests/unit/-private/compatibility-test.js, which I could not figure out.
Removing a new test :(
to avoid setContext deprecation
ro0gr
force-pushed
the
setContext-free
branch
from
68039e9
to
0c4e942
Compare
since we can recognize if it's moduleForComponent using @ember/test-helpers API It also changes priority of execution_contexts, so RFC268 mode becomes a default one, if supported.
ro0gr
force-pushed
the
setContext-free
branch
from
ba8c125
to
9df3b28
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444
moduleForComponent+setContextwas a point of much confusion for ages. With @ember/test-helpers we are able to auto-detect if it'smoduleForComponentkind of test or not.