Convert test suite to TS #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0gr
force-pushed
the
ts-tests
branch
2 times, most recently
from
a0beff1
to
33d5913
Compare
ro0gr
commented
Jan 22, 2020
| "noUnusedLocals": true, | ||
| "noUnusedParameters": true, | ||
| "noImplicitReturns": true, | ||
| "noEmitOnError": true, |
There was a problem hiding this comment.
This fails the build in case of any TS build error occurs for both development and CI.
It may be not convenient for everyone, especially for people who are new with TS, or those who just want to quickly experiment and not to fight with types.
So, if anyone knows a way to only enable such behavior on Travis, hints/suggestions are welcome!
It uses ec-typescript@1, cause more recent versions of ec-typescipt require ember-cli-babel@7 or higher. And that requires node@6 or higher, which is technically a breaking change, cause we support node@4.5 in v1 However, we use blueprint setup from ec-ts@3 here to have the best we can for now. The other changes: - Setup build to fail on TS error - remove dtslint
- Add loader.js "require" types
- Some of test helpers which are time consuming to truly convert got
ambient types, since it's not really critical for testing our public
APIs
- Simpler test helpers were converted to TS
ro0gr
force-pushed
the
ts-tests
branch
2 times, most recently
from
d068b4c
to
7c4b3d2
Compare
Caveats: - "multiple" on props is allowed to be un-typed, cause this behavior ha to be deprecated - Allow legacy collection API to be un-typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow to truly test our public APIs, w/o relying on synthetic dtslint tests.
An intention is to only convert tests which don't use deprecated(or almost deprecated) APIs. Even this way quite few typings issues were detected and some of them fixed in this PR.
Unfortunately I had to pin to ec-ts@1, cause on a later versions ec-babel@7 or higher is required, and it requires node@6 or higher. And that would be a breaking change, cause currently we have node@4.5 listed in our engines. So upgrade of ec-ts should be done with the next major version.
todo: