Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors from visitable #640

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Commits on Feb 28, 2024

  1. Better errors from visitable

    This adds the actual error message from Ember's router to the (too generic) message from `visitable`. This is especially important when your test needs to know what kind of error was triggered. For example some tests might want to handle `TransitionAborted` errors differently, see emberjs/ember-test-helpers#332 (comment).
    simonihmig committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2eed933 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Configuration menu
    Copy the full SHA
    5754361 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. preserve original error instance

    ...under the `cause.error`
    ro0gr committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e485026 View commit details
    Browse the repository at this point in the history
  2. doc: add a brief note about the cause.error

    in the `visitable` error instance
    ro0gr committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9e0ca49 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge pull request #1 from ro0gr/preserve-orig-error-instance

    Preserve original error instance
    simonihmig committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    72aa2d8 View commit details
    Browse the repository at this point in the history