-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One point zero #91
Merged
Merged
One point zero #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
220d063
to
42931cd
Compare
Remove `textList` property and use a flag on `text` property to return multiple values
This commit changes the behavior of `.isVisible` property to not raise an exception when the element doesn't exist in the DOM. The idea is to make `.isVisible` and `.isHidden` symmetric.
`.isVisible` returns false if element doesn't exist
* Predicates and queries throw error when DOM lookups return more than one element. * multiple: true option overrides this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress!
To do
Required
build
methodcomponent
propertyresetScope
option to all propertiescount
attribute 😄index
toat
import { create, text, count } from './page-object'
Nice to have
visitable
method signature (is there a better alternative?)ENV.APP.LOG_RESOLVER
does)text('span', { multiple: true })