-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
I've merged #65, can you update this PR to avoid using async/await in tests? |
@san650 Done! We can keep the async/await as that test is executed in the browser and transpiled with Babel. However, I did need to polyfill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep backward compatibility it would be great if we make this file to be opt-in instead of opt-out. So we don't override browserconfig.xml on projects that already have one.
The idea would be that by default we don't generate it and when the ms
configuration is truthy we would generate it, with ms: true
or ms: { ... }
What do you think @YoranBrondsema ?
README.md
Outdated
@@ -383,6 +418,7 @@ icons: [ | |||
| `ms` | does not apply (for now) | |||
| `android` | does not apply | |||
| `favicon` | `<link rel="icon" href="/bar/fav.png" sizes="32x32">` | |||
| `ms` | icon in `browserconfig.xml` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the reference to ms
above (three lines above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I agree! I'll make the changes. |
@san650 I made the changes. If the I added the |
Thanks for contributing this feature @YoranBrondsema !!! |
Generates
browserconfig.xml
according to the spec on https://msdn.microsoft.com/en-us/library/dn320426(v=vs.85).aspx. This targets Windows machines. It only populates the<tile>
property, not<badge>
or<notification>
.It will need some refactoring first if PR #65 gets merged first.