-
Notifications
You must be signed in to change notification settings - Fork 19
Add a section to the README for icon generation #74
Conversation
@jrjohnson as you can see, one of the original ideas of the addon was to tackle the image generation as one of the features, but I'm glad there's a different addon that do that work! I like the documentation you added, I left some comments. Let me know your thoughts! |
README.md
Outdated
@@ -53,6 +49,7 @@ See the [documentation](#documentation) section below for more information. | |||
* [`apple.webAppCapable`](#applewebappcapable) | |||
* [`ms`](#ms) | |||
* [`ms.tileColor`](#mstilecolor) | |||
* [Generating Icons](#ieneratingicons) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the link is not correct, it should be #generatingicons
README.md
Outdated
@@ -732,6 +729,48 @@ manifest.ms = { | |||
}; | |||
``` | |||
|
|||
## Generating Icons | |||
|
|||
Managing all the various icon sizes and types can be overwhelming. One solution is to start with a base image which can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a paragraph above this one to make it clear that you have to install this other addon first.
ember-web-app doesn't generate icons or images. If you want to automate the generation of icons starting from a master image, you can install ember-cli-image-transformer.
What do you think? So people don't get the wrong idea that this addon installs ember-cli-image-transformer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, that will be a lot clearer.
README.md
Outdated
"type": "image/png" | ||
} | ||
] | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea here, maybe we can use the same size array that you use in the other config. I like to give users ideas on how to make the config a bit more DRY 😄
// config/manifest.js
export default function() {
return {
icons: [192, 512].map((size) => ({
src: `/images/icons/android-chrome-${size}.png`,
sizes: `${size}`,
type: "image/png"
}))
};
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this especially. I'm 100% going to steal it to improve our manifest.js
!
Thanks for the quick feedback @san650. Those all looks like great additions. I will try and get them done in the next 24 hours. |
c290d6b
to
abae131
Compare
Uses the ember-cli-image-transformer addon to convert a single image into multiple needed icon sizes.
abae131
to
a7a8966
Compare
I ended up having some time tonight, so these changes are made now. |
Thanks for contributing! |
Uses the ember-cli-image-transformer addon to convert a single image
into multiple needed icon sizes.
@san650 as we discussed in Slack here are some basic docs for using
ember-cli-image-transformer
to build icons for web apps. I wasn't too sure what should be included here so please let me know if I missed the mark.