Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to run jq as detached process #636

Merged
merged 2 commits into from
Oct 24, 2023
Merged

option to run jq as detached process #636

merged 2 commits into from
Oct 24, 2023

Conversation

sovcharenko
Copy link
Contributor

@sovcharenko sovcharenko commented Oct 23, 2023

when an app receives SIGTERM it propagates it to a child jq process and node-jq throws an error.

this makes graceful shutdown of an app impossible.

this PR allows jq to run as detached process so that SIGTERM is not propagated allowing it to exit normally.

@davesnx
Copy link
Member

davesnx commented Oct 24, 2023

Hey, Thanks for the PR. Can you include a section into the REAMDE in form of docs? I belieb this can be useful to others as well

@sovcharenko
Copy link
Contributor Author

Done @davesnx , have a look. I also added simple docs for cwd as they were missing

@davesnx davesnx merged commit 82be730 into sanack:main Oct 24, 2023
10 checks passed
@sovcharenko
Copy link
Contributor Author

qq - any chance new version will be released soon?

@davesnx
Copy link
Member

davesnx commented Oct 24, 2023

Commits were not annotated properly, will run a release now.

@sovcharenko
Copy link
Contributor Author

hm something's wrong. version 4.0.1 doesn't incorporate my changes

@davesnx
Copy link
Member

davesnx commented Oct 24, 2023

Something seems broken in our release process, released a 4.0.2: https://github.com/sanack/node-jq/releases/tag/v4.0.2

@sovcharenko
Copy link
Contributor Author

sovcharenko commented Oct 24, 2023

looks like there is a new problem

this is how installed node-js looks:

Screenshot_of_IntelliJ_IDEA

lib has 'old' code, while src is the latest

and package.json main refers to the stale code.

@sovcharenko
Copy link
Contributor Author

feels like npm run build and npm run copy-ts-defintions didn't run during release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants