Skip to content

Commit

Permalink
Ignore offsets in VTT text tracks
Browse files Browse the repository at this point in the history
  • Loading branch information
Sanborn Hilland committed Nov 18, 2016
1 parent 1288111 commit efc1b00
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 0 additions & 3 deletions lib/media/vtt_text_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ shaka.media.VttTextParser.parseCue_ =
shaka.util.Error.Code.INVALID_TEXT_CUE);
}

start += offset;
end += offset;

// See issue #480 for discussion on deprecation
if (useRelativeCueTimestamps) {
start += segmentStartTime;
Expand Down
4 changes: 2 additions & 2 deletions test/media/vtt_text_parser_unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ describe('VttTextParser', function() {
'Test');
});

it('accounts for offset', function() {
it('ignores offset', function() {
verifyHelper(
[
{start: 27, end: 47, text: 'Test'}
{start: 20, end: 40, text: 'Test'}
],
'WEBVTT\n\n' +
'00:00:20.000 --> 00:00:40.000\n' +
Expand Down

0 comments on commit efc1b00

Please sign in to comment.