Add Map.delete to remove statistic on client

fixes hazelcast#14471
sancar · Feb 21, 2019 · e6009b0 · e6009b0
1 parent b04e92c
commit e6009b0
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/...lcast/src/main/java/com/hazelcast/client/impl/protocol/task/map/MapDeleteMessageTask.java b/...lcast/src/main/java/com/hazelcast/client/impl/protocol/task/map/MapDeleteMessageTask.java
@@ -19,6 +19,7 @@
 import com.hazelcast.client.impl.protocol.ClientMessage;
 import com.hazelcast.client.impl.protocol.codec.MapDeleteCodec;
 import com.hazelcast.instance.Node;
+import com.hazelcast.map.impl.MapContainer;
 import com.hazelcast.map.impl.MapService;
 import com.hazelcast.map.impl.operation.MapOperation;
 import com.hazelcast.map.impl.operation.MapOperationProvider;
@@ -32,6 +33,8 @@
 public class MapDeleteMessageTask
         extends AbstractMapPartitionMessageTask<MapDeleteCodec.RequestParameters> {
 
+    private transient long startTimeNanos;
+
     public MapDeleteMessageTask(ClientMessage clientMessage, Node node, Connection connection) {
         super(clientMessage, node, connection);
     }
@@ -44,6 +47,22 @@ protected Operation prepareOperation() {
         return op;
     }
 
+    @Override
+    protected void beforeProcess() {
+        startTimeNanos = System.nanoTime();
+    }
+
+    @Override
+    protected void beforeResponse() {
+        final long latencyNanos = System.nanoTime() - startTimeNanos;
+        final MapService mapService = getService(MapService.SERVICE_NAME);
+        MapContainer mapContainer = mapService.getMapServiceContext().getMapContainer(parameters.name);
+        if (mapContainer.getMapConfig().isStatisticsEnabled()) {
+            mapService.getMapServiceContext().getLocalMapStatsProvider().getLocalMapStatsImpl(parameters.name)
+                    .incrementRemoveLatencyNanos(latencyNanos);
+        }
+    }
+
     @Override
     protected MapDeleteCodec.RequestParameters decodeClientMessage(ClientMessage clientMessage) {
         return MapDeleteCodec.decodeRequest(clientMessage);

diff --git a/hazelcast/src/test/java/com/hazelcast/map/LocalMapStatsTest.java b/hazelcast/src/test/java/com/hazelcast/map/LocalMapStatsTest.java
@@ -162,6 +162,17 @@ public void run()
         });
     }
 
+    @Test
+    public void testDelete() throws Exception {
+        IMap<Integer, Integer> map = getMap();
+        for (int i = 0; i < 100; i++) {
+            map.put(i, i);
+            map.delete(i);
+        }
+        LocalMapStats localMapStats = geMapStats();
+        assertEquals(100, localMapStats.getRemoveOperationCount());
+    }
+
     @Test
     public void testRemove() throws Exception {
         IMap<Integer, Integer> map = getMap();