Fix salesagility#5303 - PHP Warnings on SugarWidgetFieldName and Suga…

…rWidgetFieldId
sanchezfauste · Jun 5, 2018 · ac9e4ac · ac9e4ac
1 parent 73aa15d
commit ac9e4ac
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 14 deletions.
diff --git a/include/generic/SugarWidgets/SugarWidgetFieldenum.php b/include/generic/SugarWidgets/SugarWidgetFieldenum.php
@@ -88,7 +88,7 @@ public function queryFilteris_not($layout_def) {
 		return $this->_get_column_select($layout_def)." <> ".$this->reporter->db->quoted($input_name0)."\n";
 	}
 
-	public function queryFilterone_of($layout_def) {
+	public function queryFilterone_of($layout_def, $rename_columns = true) {
 		$arr = array ();
 		foreach ($layout_def['input_name0'] as $value) {
 			$arr[] = $this->reporter->db->quoted($value);

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldid.php b/include/generic/SugarWidgets/SugarWidgetFieldid.php
@@ -42,7 +42,7 @@
 class SugarWidgetFieldId extends SugarWidgetReportField
 {
 
- function queryFilterIs(&$layout_def)
+ function queryFilterIs($layout_def)
  {
 		return $this->_get_column_select($layout_def)."='".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
  }

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldmultienum.php b/include/generic/SugarWidgets/SugarWidgetFieldmultienum.php
@@ -62,7 +62,7 @@ public function queryFilternot_one_of(&$layout_def) {
 		return '('.$query.')';        
 	}
 
-    public function queryFilterone_of(&$layout_def) {
+    public function queryFilterone_of($layout_def, $rename_columns = true) {
         //Fix for inaccurate filtering of contacts in Contacts dashlet on multiselects.
         $arr = array();
         foreach ($layout_def['input_name0'] as $value) {

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldname.php b/include/generic/SugarWidgets/SugarWidgetFieldname.php
@@ -67,7 +67,7 @@ function SugarWidgetFieldName(&$layout_manager){
     }
 
 
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		if(empty($layout_def['column_key']))
 		{

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldsingleenum.php b/include/generic/SugarWidgets/SugarWidgetFieldsingleenum.php
@@ -43,7 +43,7 @@
 
 class SugarWidgetFieldSingleEnum extends SugarWidgetFieldEnum {
 
-    function displayInput(&$layout_def) {
+    function displayInput($layout_def) {
         global $app_list_strings;
 
         if(!empty($layout_def['remove_blank']) && $layout_def['remove_blank']) {

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldtext.php b/include/generic/SugarWidgets/SugarWidgetFieldtext.php
@@ -62,7 +62,7 @@ function SugarWidgetFieldText(&$layout_manager){
     }
 
 
-    function queryFilterEquals($layout_def)
+    function queryFilterEquals(&$layout_def)
     {
         return $this->reporter->db->convert($this->_get_column_select($layout_def), "text2char").
         	" = ".$this->reporter->db->quoted($layout_def['input_name0']);

diff --git a/include/generic/SugarWidgets/SugarWidgetFielduser_name.php b/include/generic/SugarWidgets/SugarWidgetFielduser_name.php
@@ -43,7 +43,7 @@
 
 class SugarWidgetFielduser_name extends SugarWidgetFieldname
 {
- function displayInput(&$layout_def) 
+ function displayInput($layout_def) 
  {
         $selected_users = empty($layout_def['input_name0']) ? '' : $layout_def['input_name0'];
  		$str = '<select multiple="true" size="3" name="' . $layout_def['name'] . '[]">' . get_select_options_with_id(get_user_array(false), $selected_users) . '</select>';

diff --git a/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php b/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php
@@ -90,7 +90,7 @@ function queryFilterEnds_With(&$layout_def)
 		return $this->_get_column_select($layout_def)." LIKE '%".$GLOBALS['db']->quote($layout_def['input_name0'])."'\n";
  }
 
- function queryFilterone_of(&$layout_def)
+ function queryFilterone_of($layout_def, $rename_columns = true)
  {
     foreach($layout_def['input_name0'] as $key => $value) {
         $layout_def['input_name0'][$key] = $GLOBALS['db']->quote($value);

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php b/include/generic/SugarWidgets/SugarWidgetSubPanelConcat.php
@@ -45,7 +45,7 @@
 
 class SugarWidgetSubPanelConcat extends SugarWidgetField
 {
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		$value='';
 		if (isset($layout_def['source']) and is_array($layout_def['source']) and isset($layout_def['fields']) and is_array($layout_def['fields'])) {

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php b/include/generic/SugarWidgets/SugarWidgetSubPanelEditRoleButton.php
@@ -50,7 +50,7 @@ function displayHeaderCell(&$layout_def)
 		return '&nbsp;';
 	}
 
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		global $app_strings;
         global $subpanel_item_count;

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelEditSecurityGroupUserButton.php b/include/generic/SugarWidgets/SugarWidgetSubPanelEditSecurityGroupUserButton.php
@@ -53,7 +53,7 @@ function displayDetail($layout_def) {
 		return displayList($layout_def);
 	}
 
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		global $app_strings;
 		global $image_path;

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelRelFieldEditButton.php b/include/generic/SugarWidgets/SugarWidgetSubPanelRelFieldEditButton.php
@@ -50,7 +50,7 @@ function displayHeaderCell(&$layout_def)
 		return '&nbsp;';
 	}
 
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		die("<pre>" . print_r($layout_def, true) . "</pre>");
 

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelRemoveButtonAccount.php b/include/generic/SugarWidgets/SugarWidgetSubPanelRemoveButtonAccount.php
@@ -47,7 +47,7 @@ class SugarWidgetSubPanelRemoveButtonAccount extends SugarWidgetSubPanelRemoveBu
 	 * 
 	 * @see SugarWidgetSubPanelRemoveButton::displayList()
 	 */
-	function displayList(&$layout_def) {
+	function displayList($layout_def) {
 		if (!$layout_def['EditView']) {
 			return false;
 		}

diff --git a/include/generic/SugarWidgets/SugarWidgetSubPanelRemoveButtonProjects.php b/include/generic/SugarWidgets/SugarWidgetSubPanelRemoveButtonProjects.php
@@ -50,7 +50,7 @@ function displayHeaderCell(&$layout_def)
 		return '&nbsp;';
 	}
 
-	function displayList(&$layout_def)
+	function displayList($layout_def)
 	{
 		global $app_strings;