-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The code polishing #11
Comments
Thanks |
I guess a lot of methods of Command class can be removed as well maybe some other methods may be removed also.. the main idea is the MOST methods MUST be inherited from a parent class $_sql & $_pendingParams must be removed as well |
I do not remember ((( getSql, setSql, queryAll, queryOne - removed |
Let's make the code more beautiful and compact :)
for example, properties
public $db;
public $params = [];
...
and so on
must be removed from your class
some unnecessary methods should be removed as well
I checked only Command class, but I guess other classes may be affected as well.
Please fix it.
https://github.com/sanchezzzhak/kak-clickhouse/blob/master/Command.php#L332
I guess preg_match may be replaced with stripos here
to be continued :)
The text was updated successfully, but these errors were encountered: