Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Readme #30

Merged
merged 2 commits into from
Oct 24, 2020
Merged

updated Readme #30

merged 2 commits into from
Oct 24, 2020

Conversation

ancasimon
Copy link
Contributor

@ancasimon ancasimon commented Oct 24, 2020

  1. Updated Readme to include description, background, tech stack, features, backlog, contribution info, and icons for each section.
  2. Also added a new jpg file to the assets folder that gets displayed at the top of the Readme: airplane-wing-sky.jpg
  3. IMPORTANT NOTE: I noticed that the package-lock.json file got pulled into the changed files for this PR and I guess I didn't expect it to .... Is that ok?? Here's what the file looks like for me:

Screen Shot 2020-10-23 at 8 29 29 PM

1. Last but not least: I would like to add some screenshots to the Readme. Once I get the app actually working, I will take those screenshots and add them in. 1. Of course, please let me know of any changes you would like to see!

…es, backlog, contribution info, and icons for each section
@sanchit2107
Copy link
Owner

Refer to your

  1. Updated Readme to include description, background, tech stack, features, backlog, contribution info, and icons for each section.
  2. Also added a new jpg file to the assets folder that gets displayed at the top of the Readme: airplane-wing-sky.jpg
  3. IMPORTANT NOTE: I noticed that the package-lock.json file got pulled into the changed files for this PR and I guess I didn't expect it to .... Is that ok?? Here's what the file looks like for me:
Screen Shot 2020-10-23 at 8 29 29 PM
  1. Last but not least: I would like to add some screenshots to the Readme. Once I get the app actually working, I will take those screenshots and add them in. 1. Of course, please let me know of any changes you would like to see!

Refer to ur point 3, actually you were not able to install npm dependencies. That's why the file is just like that only.

Yes for sure you can add them any time whenever you have the application running in ur system

I will review the PR and will merge with the required comment on changes if any.

1. Processing payments


## 🤝 Contributors
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name as well in your next PR here.

@ancasimon

Will be great to see your name also here on the contributor list.

Due to insufficient data.
Copy link
Owner

@sanchit2107 sanchit2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work by you.

Thanks to @ancasimon

@sanchit2107 sanchit2107 merged commit 1828adb into sanchit2107:master Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants