modify AnyFunction to include generator functions

[arsaniwilliam]

Using typeofEq('function') for the AnyFunction to include generator functions.
Note: The test uses a generator function (function*(x){... ) but that causes the es3 linter to report a parse error on the *.. Is there any way to avoid this?

[davidchambers]

The fix for the parsing error may be to remove --env es3 from the value assigned to ESLINT in the makefile, and to specify $(ESLINT) --env es6 ... -- test. Give that a go. :)

[arsaniwilliam]

@davidchambers that worked. thank you!

[davidchambers]

The order in which --env values are provided isn't significant, but I like --env es6 --env node --env mocha as language-version > engine > framework seems like the appropriate hierarchy. I love to avoid making arbitrary decisions. :)

Also, please add --env es3 to the $(ESLINT) ... -- index.js command.

[arsaniwilliam]

any preference to where the --env es3 should go in the -- index.js command? :)

[davidchambers]

Let's put it first there too. :)

[arsaniwilliam]

that's what I thought :)

[davidchambers]

This looks great, Arsani!

As a last step please squash the commits and --force push:

$ git rebase 829cece41561c879b2ff040d1ed269f75ba72e2c^ --interactive
$ git push origin AnyFunction-IncludeGeneratorType --force

While you're at it, I suggest shortening the commit message to match the pull request title:

-modify the AnyFunction to include generator functions, by using typeofEq('function').
+modify AnyFunction to include generator functions

It's advisable to avoid lines longer than 72 characters in a commit message. :)

[arsaniwilliam]

done!

[davidchambers]

Very nice!

The commit is not being mapped to your GitHub account. If this bothers you, you can fix the issue by telling GitHub about the email address you included in the commit, or by amending the commit to use the same email address you use on GitHub. If this doesn't bother you, I'll go ahead and merge.

[arsaniwilliam]

I made my email public on github.. are there any more steps I need to take?

[arsaniwilliam]

fixed the author and email on the commit..

[arsaniwilliam]

@davidchambers Thanks again for all your help.
Feel free to merge if you'd like :)

[davidchambers]

I just noticed that this is es6 rather than es3. Let's keep it as es3 to ensure that we don't accidentally sneak ES6 features into the source code (it's okay to use ES6 features in the test suite).

Please update the commit with git commit --amend. You'll then need to use --force when you push to your branch.

[arsaniwilliam]

whoops... good catch.
fixed.