types: define Buffer #294
types: define Buffer #294
Conversation
| (function(x) { | ||
| return typeof Buffer !== 'undefined' && | ||
| // eslint-disable-next-line no-undef | ||
| Buffer.isBuffer (x); | ||
| }); |
There was a problem hiding this comment.
The following implementation is more elegant but less conducive to maintaining 100% branch coverage:
(typeof Buffer === 'undefined' ? K (false) : Buffer.isBuffer)
test/index.js
Outdated
| (Buffer => { | ||
| delete global.Buffer; | ||
| try { | ||
| eq (isBuffer (null)) (false); | ||
| eq (isBuffer (Buffer.from ([1, 2, 3]))) (false); | ||
| } finally { | ||
| global.Buffer = Buffer; | ||
| } | ||
| }) (Buffer); |
There was a problem hiding this comment.
delete global.Buffer removes our ability to reference Buffer implicitly, so we must retain an explicit reference. (Buffer => …) (Buffer) strikes me as more elegant than const Buffer_ = Buffer; ….
There was a problem hiding this comment.
What about const Buffer = global.Buffer?
There was a problem hiding this comment.
Good idea. I did not consider { const Buffer = global.Buffer; … }.
|
The code and approach look good to me. However, I would've probably separated any environment-specific types out into their own packages. I could imagine |
|
Providing separate packages for various environments is certainly an option worth considering. :) |
davidchambers
force-pushed
the
davidchambers/buffer
branch
from
3e3d816
to
25baaf0
Compare
This was recently requested by @jceb in sanctuary-js/sanctuary#575.