use ES6 syntax #73
Merged
use ES6 syntax #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidchambers
commented
Jan 20, 2022
Comment on lines
-337
to
+299
| var def = $.create ({checkTypes: true, env: $.env}); | ||
| return (Object.keys (_)).reduce (function(int, name) { | ||
| int[name] = def (name) ({}) (_[name].types) (_[name].impl); | ||
| { | ||
| const def = $.create ({checkTypes: true, env: $.env}); | ||
| const int = {Int, NonZeroInt}; | ||
| for (const name of Object.keys (_)) { | ||
| const {types, impl} = _[name]; | ||
| int[name] = def (name) ({}) (types) (impl); | ||
| } | ||
| return int; | ||
| }, {Int: Int, NonZeroInt: NonZeroInt}); | ||
| } |
There was a problem hiding this comment.
I prefer this imperative approach, now that we have access to block-scoped variables.
I did not use Object.entries as it was not specified in ES6.
Avaq
approved these changes
Feb 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanctuary-js/sanctuary#687