Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'module-type' option determining how README is linted #26

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

Avaq
Copy link
Member

@Avaq Avaq commented Apr 2, 2019

Changes

  • Update doctest to the latest version
  • Expose doctest' new ESM feature through a module-type setting that users can add in their .config. This option also ensures that code examples are treated as "modules" by the linter.

@Avaq Avaq force-pushed the avaq/doctest-module-type branch from 5d5803a to cd7c1c9 Compare April 2, 2019 07:58
README.md Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch from 5507ab1 to d4b7db6 Compare April 2, 2019 08:05
bin/lint-readme Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch from d4b7db6 to 4f6d329 Compare April 2, 2019 08:07
bin/lint-readme Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch 2 times, most recently from 0ab1e50 to 20aa3d0 Compare April 2, 2019 08:11
README.md Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch 2 times, most recently from ae8bfe9 to e2596fc Compare April 3, 2019 08:17
functions Outdated Show resolved Hide resolved
bin/doctest Outdated Show resolved Hide resolved
bin/doctest Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch from b191ccd to 778ac24 Compare April 3, 2019 10:33
package.json Outdated Show resolved Hide resolved
@Avaq Avaq force-pushed the avaq/doctest-module-type branch from c9787a4 to f49f0f8 Compare April 3, 2019 13:25
@Avaq Avaq marked this pull request as ready for review April 3, 2019 13:27
README.md Outdated Show resolved Hide resolved
@davidchambers
Copy link
Member

I left one last suggestion. Aside from that, everything looks very good to me. Let's squash and merge. :)

@Avaq Avaq force-pushed the avaq/doctest-module-type branch from 5fe9c1b to 39dcbe3 Compare April 4, 2019 11:21
@Avaq Avaq merged commit 52c4da1 into master Apr 4, 2019
@Avaq Avaq deleted the avaq/doctest-module-type branch April 4, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants