lint-commit-messages: count multibyte characters intelligently #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
LC_CTYPE
is not set appropriately,grep
miscounts the characters in this commit message:The commit message actually contains 66 rather than 74 characters, if the multibyte characters are counted intelligently:
The fix provided in this pull request is to specify
LC_CTYPE=C.UTF-8
ifC.UTF-8
is one of the available locales.Another solution would be to encourage users to set
LC_CTYPE
locally and on their continuous integration servers, but I think we should make an effort to count characters correctly no matter how the system is configured.