use ES6 syntax #156
Merged
use ES6 syntax #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avaq
reviewed
Apr 24, 2021
|
|
||
| 'use strict'; | ||
|
|
||
| /* istanbul ignore if */ | ||
| if (typeof __doctest !== 'undefined') { | ||
| /* eslint-disable no-unused-vars */ | ||
| /* eslint-disable no-unused-vars, no-var */ |
There was a problem hiding this comment.
Interesting. I never thought to use var as a feature. :)
Avaq
reviewed
Apr 24, 2021
index.js
Outdated
| var functionName = has ('name', Function) ? | ||
| function functionName(f) { return f.name; } : | ||
| const functionName = ( | ||
| has ('name', Function) ? |
There was a problem hiding this comment.
Do we still need to consider the fallback for function names? Wasn't that an es5-support thing?
There was a problem hiding this comment.
Good point! You are correct: ECMAScript 2015 Language Specification § 19.2.4.2.
There was a problem hiding this comment.
Yeah, and depending on the outcome of this #151 (comment) discussion, we may end up removing the functionName function altogether.
Avaq
approved these changes
Apr 24, 2021
davidchambers
force-pushed
the
davidchambers/es6
branch
from
3ce67d5
to
db087cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanctuary-js/sanctuary#687