Implement S.add and S.sub #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svozza
force-pushed
the
add-subtract-functions
branch
3 times, most recently
from
90e9689
to
847db85
Compare
| //. 2 | ||
| //. ``` | ||
| S.add = | ||
| def('add', |
svozza
force-pushed
the
add-subtract-functions
branch
from
847db85
to
609b121
Compare
|
Is there value in using the same names as sanctuary-int, do you think? We use |
|
Yeah, I guess it doesn't do any harm to be consistent. I was just following the naming convention from Ramda. |
svozza
force-pushed
the
add-subtract-functions
branch
from
609b121
to
f9f574d
Compare
| [$.FiniteNumber, $.FiniteNumber, $.FiniteNumber], | ||
| function(a, b) { return a + b; }); | ||
|
|
||
| //# subtract :: FiniteNumber -> FiniteNumber -> FiniteNumber |
There was a problem hiding this comment.
s/subtract/sub/
Could you update the commit message and pull request title to match? :)
svozza
force-pushed
the
add-subtract-functions
branch
from
f9f574d
to
8703e97
Compare
svozza
force-pushed
the
add-subtract-functions
branch
from
8703e97
to
324419f
Compare
| errorEq(TypeError, | ||
| '‘sub’ expected a value of type FiniteNumber ' + | ||
| 'as its second argument; received "xxx"')); | ||
| }); |
There was a problem hiding this comment.
It would be nice to use an infinite number in one of these tests. ∞
svozza
force-pushed
the
add-subtract-functions
branch
from
324419f
to
fbbd2e9
Compare
|
|
||
| //# add :: FiniteNumber -> FiniteNumber -> FiniteNumber | ||
| //. | ||
| //. Adds two finite numbers together. |
There was a problem hiding this comment.
For the descriptions, I like:
- Returns the sum of two (finite) numbers.
- Returns the difference between two (finite) numbers.
svozza
force-pushed
the
add-subtract-functions
branch
from
fbbd2e9
to
ea196e9
Compare
|
⚡ x 3 |
| //. Returns the sum of two (finite) numbers. | ||
| //. | ||
| //. ```javascript | ||
| //. > S.add(1, 1); |
svozza
force-pushed
the
add-subtract-functions
branch
from
ea196e9
to
f2f1cd3
Compare
svozza
force-pushed
the
add-subtract-functions
branch
from
f2f1cd3
to
ee92e3e
Compare
|
⚡ x 2 |
|
🌳 |
davidchambers
added a commit
that referenced
this pull request
Jan 27, 2016
Implement S.add and S.sub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #127 .