function: remove S.curry2, S.curry3, S.curry4, and S.curry5 #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bradcomp
reviewed
Aug 11, 2020
| }; | ||
| }; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Are these functions used within the codebase? Why are we keeping them around?
There was a problem hiding this comment.
These functions are used to curry Z functions. curry4 is applied exactly once: curry4 (Z.lift3).
davidchambers
force-pushed
the
davidchambers/no-curry
branch
from
f5894a4
to
a1a9ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanctuary's
curry*functions were added in late 2016 (#289). In the intervening years, arrow function expressions have become widely supported (#687). Arrow function expressions make manual currying painless, so these functions no longer provide significant value.The primary motive for removing these functions is to reduce the library's surface area. The other reason is that currying a “foreign” function is rarely the only change one should make. Other possible changes include:
Maybe StringtoNullable String);Promise UsertoFuture Error User); andSanctuary's
curry*functions discourage consideration of such potential API improvements./cc @laduke