regexp: simplify return types of S.match and S.matchAll #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match
andmatchAll
are currently not enjoyable to use. I know why the return types are complex, but I still find accessing captured values annoying:This pull request simplifies the match type, making captured values easier to access:
Before:
After:
Losing
match :: String
is not a problem in most cases, for the reason given in #686:Interestingly, the proposed type of
match
is the same as the function's type prior to #283. The incoherence @rjmk exposed in #253 does not apply, though, as the match is now omitted rather than prepended to the array of captured values.