Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fantasy-land: document use of S.lift2 and S.lift3 as combinators #700

Merged
merged 1 commit into from May 2, 2021

Conversation

davidchambers
Copy link
Member

sanctuary-js/sanctuary-site#92

In addition to documenting the use of lift2 and lift3 as combinators, this pull request standardizes the steps for deriving signatures of combinators from more general signatures:

  1. Provide general signature:

    Functor f => (a -> b) -> f a -> f b
  2. Replace type variable with Function x:

    (a -> b) -> Function x a -> Function x b
  3. Convert to -> form:

    (a -> b) -> (x -> a) -> (x -> b)
  4. Remove unnecessary parentheses:

    (a -> b) -> (x -> a) -> x -> b
  5. Rename type variables:

    (b -> c) -> (a -> b) -> a -> c

@davidchambers davidchambers requested a review from a team August 29, 2020 19:51
Copy link
Member

@Bradcomp Bradcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:bowtie:

@Avaq
Copy link
Member

Avaq commented Dec 30, 2020

Any reason to hold off merging this @davidchambers ?

@davidchambers
Copy link
Member Author

Any reason to hold off merging this @davidchambers ?

No reason whatsoever. :)

@davidchambers davidchambers merged commit 4383356 into master May 2, 2021
@davidchambers davidchambers deleted the davidchambers/lift branch May 2, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants