Added simple support for setting attributes on a component, pretty mu… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch the same code as the property handling with an additional test for boolean attribute special cases
sand4rt
force-pushed
the
master
branch
2 times, most recently
from
96b2853
to
0d9ce4a
Compare
|
Nice adding, can I just suggest that we could have something similar for data attributes? something like: function __pwUpdateDataAttributes(webComponent, dataattributes = {}) {
Object.assign(webComponent.dataset, dataattributes)
} |
sand4rt
force-pushed
the
master
branch
5 times, most recently
from
47af38a
to
69d9b5b
Compare
Could you file a new issue including the use case? Then i can look into this. |
sand4rt
force-pushed
the
master
branch
2 times, most recently
from
fde625b
to
5f88cd2
Compare
Closed
Created #11 |
sand4rt
force-pushed
the
master
branch
2 times, most recently
from
69dcd6c
to
77c4956
Compare
|
Closed due to inactivity, feel free to reopen when needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ch the same code as the property handling with an additional test for boolean attribute special cases
closes: #5