Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plus only] Disable Turkish for inactivity #1215

Merged
merged 2 commits into from Sep 19, 2021
Merged

[Plus only] Disable Turkish for inactivity #1215

merged 2 commits into from Sep 19, 2021

Conversation

isaak654
Copy link
Collaborator

@isaak654 isaak654 commented Sep 19, 2021

There is a concrete risk of a translation mismatch because of the continuos Plus UI changes. Since the latest Turkish update, more than 20 versions were released, so the Plus support for Turkish should be turned off.

If you want to update and restore the translation for Sandboxie Plus, please open a new issue.

There is a concrete risk of a translation mismatch because of the continuos Plus UI changes. Since the latest Turkish update, more than 20 versions were released, so the Plus support for Turkish should be turned off.

If you want to update and restore Plus translation, please open a new issue.
@mpheath
Copy link
Collaborator

mpheath commented Sep 19, 2021

The disabling in Languages.iss is OK. I am not sure about the parsing of SandMan.pri. Those backslashes at the end of the lines are continuation characters. The backslash and newline sequence will be stripped and the next line will be joined with the previous line.

So this effect may happen when parsed:

sandman_ru.ts sandman_tr.ts # sandman_tr.ts \ (unmaintained) sandman_zh-CN.ts sandman_zh-TW.ts

I would suggest to move the commented sandman_tr.ts down below sandman_zh-TW.ts so to avoid issues with the line continuations.

If the parser strips the comment lines, then strips the line continuations and joins the lines, then it might be OK. That I am unsure if it will do that without testing it.

@mpheath mpheath merged commit 2fb67c2 into master Sep 19, 2021
@isaak654 isaak654 deleted the turkish-plus branch September 19, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants