Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OptionsWindow.ui #3714

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

APMichael
Copy link
Contributor

Shouldn't the previous description text be used again, as it is in the changelog?

- Replaced description text.
@love-code-yeyixiao
Copy link
Contributor

This is too one-sided.I suggest keeping the original explanation.

@love-code-yeyixiao
Copy link
Contributor

It functions as it was originally explained.

@DavidXanatos DavidXanatos merged commit b7800e6 into sandboxie-plus:master Mar 17, 2024
3 checks passed
@offhub
Copy link
Collaborator

offhub commented Mar 17, 2024

If this setting does not distinguish whether applications/windows are in the sandbox or not, I think both sentences are incorrect.

@APMichael APMichael deleted the patch-1 branch March 17, 2024 12:19
@APMichael
Copy link
Contributor Author

@love-code-yeyixiao To be honest, I personally don't think that a normal user will understand your description text. David's text, on the other hand, is very understandable.

Why did you correct the changelog (#3715) before a decision was made here? Now it doesn't match again!


@offhub According to the previous texts, it refers to all windows outside the running sandbox, just as David had written. If this is not the case, then the text should be changed again.


@DavidXanatos Can you please make a decision so that the description text is the same both in the OptionsWindow.ui and in the changelog. Thank you very much!

offhub added a commit to offhub/Sandboxie that referenced this pull request Mar 18, 2024
Fixes some text inconsistencies in the interface and changelog.
sandboxie-plus#3714
sandboxie-plus#3715
offhub added a commit to offhub/Sandboxie that referenced this pull request Mar 18, 2024
Fixes some text inconsistencies between the user interface and the changelog.
sandboxie-plus#3714
sandboxie-plus#3715
offhub added a commit to offhub/Sandboxie that referenced this pull request Mar 18, 2024
Fixes some text inconsistencies between the user interface and the changelog.
sandboxie-plus#3714
sandboxie-plus#3715
@offhub offhub mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants