New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testimonial on landing page #30
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://sandboxneucom-git-testimonial.sandboxneu1.now.sh |
Yeah, I have most of the styling done for the join page. I will do the graphQL stuff with MD tomorrow and then we can get this merged. |
I think the "look no further than Sandbox" should be bold too instead of italics. Also should the background be blue so we stick to the alternating backgrounds? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm liking the no header style, I think the testimonial goes along with the projects so we don't need the extra header (especially if we put a big ol' button at the bottom). I think we should be good to merge this once the comment I left gets addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
We should move the testimonial content into a content file and load it in. However, because there is bold and italics, it should probably be in a markdown file instead of json. Might need to wait on #27 to add markdown support?