Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testimonial on landing page #30

Merged
merged 9 commits into from May 24, 2019
Merged

Testimonial on landing page #30

merged 9 commits into from May 24, 2019

Conversation

dajinchu
Copy link
Member

We should move the testimonial content into a content file and load it in. However, because there is bold and italics, it should probably be in a markdown file instead of json. Might need to wait on #27 to add markdown support?

@vercel
Copy link

vercel bot commented May 18, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://sandboxneucom-git-testimonial.sandboxneu1.now.sh

@ryandrew14
Copy link
Member

Yeah, I have most of the styling done for the join page. I will do the graphQL stuff with MD tomorrow and then we can get this merged.

@ArunJ98
Copy link
Member

ArunJ98 commented May 18, 2019

I think the "look no further than Sandbox" should be bold too instead of italics. Also should the background be blue so we stick to the alternating backgrounds?

Copy link
Member

@ryandrew14 ryandrew14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm liking the no header style, I think the testimonial goes along with the projects so we don't need the extra header (especially if we put a big ol' button at the bottom). I think we should be good to merge this once the comment I left gets addressed.

src/components/IndexPage/testimonial.js Outdated Show resolved Hide resolved
Copy link
Member

@ryandrew14 ryandrew14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/components/IndexPage/testimonial.js Show resolved Hide resolved
@dajinchu dajinchu merged commit 39d4242 into master May 24, 2019
@dajinchu dajinchu deleted the testimonial branch May 24, 2019 01:30
@ryandrew14 ryandrew14 mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants