Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards: hackaBLE fix pin mapping #333

Closed
wants to merge 1 commit into from

Conversation

Pathak94
Copy link
Contributor

There are two version of hackaBLE with different pins exposed.
This change makes nRF52832 pins map directly to Arduino pins
sequentially.

Signed-off-by: vaishali vaishali@electronut.in

There are two version of hackaBLE with different pins exposed.
This change makes nRF52832 pins map directly to Arduino pins
sequentially.

Signed-off-by: vaishali <vaishali@electronut.in>
Copy link
Collaborator

@dlabun dlabun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are two different versions of the hackaBLE with different pin outs there should be two different variants with the correct pin out for each.

@Pathak94
Copy link
Contributor Author

@dlabun, I thought about doing the same initially, but that will make things redundant. This change will make both the hackaBLE boards compatible with the same variant. We mapped each pin of Arduino controller to nordic's pin sequentially. This is the same as what Sparkfun breakout board has done for example, in their own fork of this.

Both boards have the pin numbers on the silkscreen as 'P0.21' etc. so this is easy to reference, and I have used only the pins that are common on both for Serial/SPI/I2C/LED_BUILTIN/BUTTON etc.

@dlabun
Copy link
Collaborator

dlabun commented Jan 18, 2019

I am highly concerned about breaking any existing projects with this change. If the boards are broken out differently then different variants is appropriate to maintain past functionality.

@Pathak94
Copy link
Contributor Author

Okay, I will create a new variant with this pin mapping. Thanks @dlabun

@Pathak94 Pathak94 closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants