On Linux, refresh serviceUuids for incoming advertisement #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeepmistry
added a commit
that referenced
this pull request
May 24, 2015
On Linux, refresh serviceUuids for incoming advertisement
|
@BBarash thanks, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an advertising device changes its service UUIDs, the old and redundant ones remain cached - even if they are no longer being advertised. As far as I'm aware this isn't desired behaviour, but it was causing problems in a use case I was exploring. When the service data is cleaned up, the service UUIDs should be as well.
In reality, only doing this every second event (as the implementation currently does), might not be wholly efficient as it could miss an instantaneous new service UUID - but will pick it up soon after anyway.