Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create register page #51

Merged
merged 6 commits into from
Jul 20, 2019
Merged

Create register page #51

merged 6 commits into from
Jul 20, 2019

Conversation

taraldjoh
Copy link
Collaborator

No description provided.

Copy link
Owner

@sanderhelleso sanderhelleso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall pretty good. Some minor things to improve upon:

  1. export default function Register() - Can become: const Register = () => {} with export default below the function for readability. This can be done with all functions. The above approach is preffered within the hooks community.

  2. The form can be automated by simply creating an object and map over it. Allows for readability and flexibility. This could become a new issue if you would like to try it out.

Overall, good job :)

@sanderhelleso sanderhelleso merged commit 6445625 into master Jul 20, 2019
@taraldjoh
Copy link
Collaborator Author

taraldjoh commented Jul 20, 2019

Overall pretty good. Some minor things to improve upon:

  1. export default function Register() - Can become: const Register = () => {} with export default below the function for readability. This can be done with all functions. The above approach is preffered within the hooks community.
  2. The form can be automated by simply creating an object and map over it. Allows for readability and flexibility. This could become a new issue if you would like to try it out.

Overall, good job :)

Thank you. I will be adding this as an Issue.

@taraldjoh taraldjoh deleted the Create-Register-Page branch July 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants