Add option to display higher precision point loss values #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, forgot that I'm not supposed to update the |
|
Not sure about the option (it's growing a little out of hand), but will merge and see if I defer it to a theme option instead. |
sanderland
added a commit
that referenced
this pull request
Mar 24, 2022
* Shade estimated territory (#488) * prune branch, icons * Tsumego frame (#506) * straighten quotes * Bump pillow from 9.0.0 to 9.0.1 (#511) * Bump pillow from 8.3.2 to 9.0.0 (#500) * Add option to display higher precision point loss values (#514) * fix mac build (#516) * drop 3.6 support * new katago Co-authored-by: Miles Crawford <miles@milescrawford.com> Co-authored-by: kaorahi <38910552+kaorahi@users.noreply.github.com> Co-authored-by: Hiraoka <khi@users.osdn.me> Co-authored-by: Zironic <Tony-Liou@users.noreply.github.com> Co-authored-by: pdeblanc <peter@spaceandgames.com> Co-authored-by: Dontbtme <66470440+Dontbtme@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to show more precise point loss estimates. This only applies when the absolute value is below 1, and is achieved by omitting the leading zero. For example, a value of
-0.78can be displayed as-.78rather than truncating it to-0.8. This way more information can be displayed without using a smaller font size.Maybe this seems a bit frivolous given the inherent uncertainty of point estimation, but at least it is useful for me to understand the engine's style preferences when it comes to e.g. joseki choice, where the difference between moves may be quite subtle. I assume many people have an aesthetic preference for the leading zero so this feature is controlled by an option in the Teaching/Analysis settings.