Downlevel type modifiers on import/export names for TS <4.5 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Do you think this should also cover |
|
Good point, I'll add a commit with support for exports. |
|
Done (see 62bbbe3). |
sisp
changed the title
simmo
approved these changes
Feb 20, 2022
sandersn
approved these changes
Feb 26, 2022
|
downlevel-dts@0.9.0 is now published with this change (and the new tests, thanks for those too). |
|
Awesome, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for downleveling
typemodifiers on import names introduced in TS 4.5.Please feel free to request any changes, it's my first contribution to this project and first time using the TS API. One remark: The
copyCommenthelper function seems to have a bug, it does not correctly preserve comments (see the test files).Closes #66.