Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo at cleanRubyContainers() #163

Closed
palemieux opened this issue Aug 14, 2019 · 0 comments · Fixed by #166
Closed

Typo at cleanRubyContainers() #163

palemieux opened this issue Aug 14, 2019 · 0 comments · Fixed by #166
Assignees
@palemieux
Labels
1.1 bug PR open
Milestone
1.1.1 Release

Comments

@palemieux
Copy link
Contributor

palemieux commented Aug 14, 2019 •
edited
Loading

imscJS/src/main/js/doc.js

Line 645 in 8d45889

var isrubycontainer = (element.kind === 'span' && (rubyval === "container" || rubyval === "textContainer" || rubyval === "textContainer"));

baseContainer not included in cleanup.
@palemieux palemieux self-assigned this Aug 14, 2019
palemieux added a commit that referenced this issue Sep 4, 2019
@palemieux
Ruby base containers now included in pruning algorithm (#163)
83b12e2
@palemieux palemieux mentioned this issue Sep 4, 2019
Merged
@palemieux palemieux added this to the 1.1.1 Release milestone Sep 8, 2019
palemieux added a commit that referenced this issue Sep 16, 2019
@palemieux
* Ruby base containers now included in pruning algorithm (#163)
e5518a0 
* Auto now supported by tts:textEmphasis (#158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
1.1 bug PR open
Projects
None yet
Milestone
1.1.1 Release
Development

Successfully merging a pull request may close this issue.

Fix miscellaneous issues sandflow/imscJS
1 participant
@palemieux