Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong unit in fontsize throws an exception #168

Closed
cconcolato opened this issue Oct 1, 2019 · 2 comments · Fixed by #170 or #176
Closed

Wrong unit in fontsize throws an exception #168

cconcolato opened this issue Oct 1, 2019 · 2 comments · Fixed by #170 or #176
Assignees
@palemieux
Labels
bug
Milestone
1.1.2 Release

Comments

@cconcolato
Copy link

instead of showing an error message. An example is using tts:fontSize="5vh" instead of 5rh.
@palemieux palemieux changed the title wrong unit in fontsize throws an exception Wrong unit in fontsize throws an exception Oct 3, 2019
@palemieux palemieux self-assigned this Oct 3, 2019
@palemieux palemieux added this to the 1.1.1 Release milestone Oct 3, 2019
@palemieux palemieux mentioned this issue Oct 17, 2019
Closed
palemieux added a commit that referenced this issue Oct 17, 2019
@palemieux
Use initial value if style property cannot be computed (#168)
adae0de
@palemieux palemieux mentioned this issue Oct 17, 2019
Merged
palemieux added a commit that referenced this issue Oct 22, 2019
@palemieux
Use initial value if style property cannot be computed (#168)
cb7d6c4
@cconcolato
Copy link
Author

Seems the error is still there:

<?xml version="1.0" encoding="utf-8"?>
<tt xml:lang="ja" xmlns="http://www.w3.org/ns/ttml" ttp:contentProfiles="http://www.w3.org/ns/ttml/profile/imsc1.1/text" xmlns:tts="http://www.w3.org/ns/ttml#styling" xmlns:ttm="http://www.w3.org/ns/ttml#metadata" xmlns:ttp="http://www.w3.org/ns/ttml#parameter" xmlns:xml="http://www.w3.org/XML/1998/namespace" xmlns:ittp="http://www.w3.org/ns/ttml/profile/imsc1#parameter" xmlns:ebutts="urn:ebu:tt:style" ttp:timeBase="media" ttp:frameRate="24" ttp:frameRateMultiplier="1000 1001" ttp:tickRate="10000000" >
<head>
<styling>
<initial tts:backgroundColor="transparent" tts:color="white" tts:extent="80.000% 80.000%" tts:fontFamily="Japanese" tts:fontSize="6.000vh" tts:opacity="1.000" tts:origin="10.000% 10.000%" tts:textOutline="black 0.050em" tts:writingMode="lrtb"/>
<style xml:id="style0" tts:textAlign="center"/>
<style xml:id="style2" tts:fontSize="1.500em"/>
</styling>
<layout>
<region xml:id="region0" tts:displayAlign="after" tts:extent="80.000% 80.000%" tts:origin="10.000% 10.000%"/>
</layout>
</head>
<body>
<div>
<p xml:id="subtitle42" begin="822400000t" end="831200000t" region="region0" style="style0"><span style="style2">―</span></p>
</div>
</body>
</tt>

@palemieux palemieux reopened this May 8, 2020
palemieux added a commit that referenced this issue May 12, 2020
@palemieux
Gracefully fail on invalid initial values (#168)
afc874f
@palemieux palemieux mentioned this issue May 12, 2020
Merged
@palemieux
Copy link
Contributor

@cconcolato See #176 , also deployed at http://sandflow.com/imsc1_1/index.html

palemieux added a commit that referenced this issue May 29, 2020
@palemieux
Gracefully fail on invalid initial values (#168)
7bcdf11
nigelmegitt pushed a commit to bbc/imscJS that referenced this issue Dec 11, 2020
@palemieux @nigelmegitt
Gracefully fail on invalid initial values (sandflow#168)
0278a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
bug
Projects
None yet
Milestone
1.1.2 Release
2 participants
@cconcolato @palemieux