Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adjacent textCombine spans to be merged #239

Merged
merged 5 commits into from
Nov 21, 2022

Conversation

palemieux
Copy link
Contributor

Closes #232

@palemieux palemieux self-assigned this Nov 19, 2022
@palemieux palemieux mentioned this pull request Nov 19, 2022
@palemieux
Copy link
Contributor Author

@btsimonh @nigelmegitt Please review. This is intended to clean-up #233.

See referenced renders at w3c/imsc-tests#108

@btsimonh
Copy link
Contributor

looks good to me.

src/main/js/html.js Outdated Show resolved Hide resolved
Co-authored-by: Nigel Megitt <nigel.megitt@bbc.co.uk>
@palemieux palemieux merged commit ce3b1f4 into master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjacent tts:textCombine spans are combined into a single span
3 participants