Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for buffered_caption being None in SCC reader #383

Closed
wants to merge 1 commit into from

Conversation

atsampson
Copy link
Contributor

This fixes a problem found when parsing CC data from a noisy LaserDisc: if a signal dropout corrupts the preamble for a caption, the SCC reader shouldn't crash when text is seen for that caption.

This fixes a problem found when parsing CC data from a noisy LaserDisc:
if a signal dropout corrupts the preamble for a caption, the SCC reader
shouldn't crash when text is seen for that caption.
@palemieux
Copy link
Contributor

palemieux commented Jan 27, 2023

It looks like the code throws in other places where no caption is initialized:

@atsampson Is your proposal to basically ignore 608/708 codes until the next caption?

@valnoel Any opinion?

@valnoel
Copy link
Collaborator

valnoel commented Feb 17, 2023

Hi @atsampson @palemieux !

I've completed the @atsampson suggestion by skipping captions parsing in case of no PAC is detected from the SCC stream (i.e. when the cursor position is not specified). I've added a unit test as well.

See #385

@GRDazzle
Copy link

I have run into this problem as well. I can confirm the PR change fix the issue for me.

Copy link

@GRDazzle GRDazzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested and verified with my own test case.

@palemieux
Copy link
Contributor

Mooted by #395

@palemieux palemieux closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants