Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebVTT writer: add support for 'align' (proposed fix) #414

Merged
merged 4 commits into from Nov 20, 2023

Conversation

palemieux
Copy link
Contributor

Closes #410

@ngaullier
Copy link
Contributor

Great, thank you!
In fact, I realized that I... forgot to push my changes to the PR #410... But anyway, it was not very good looking to implement both writingmode and direction in the VTT code as I implemented it.
Now, I understand how the two interacts, I have learned one thing!
Oviously, the code is much better and easier understandable this way.
I go close my original PR.
Only thing that should be kept in mind is that span-direction is not supported (I think it "cannot" be supported in vtt at all), maybe it could be documented, but anyway that kind of features is so special that people don't reasonably expect the documentation to be fully exhaustive (would certainly be overly long and never read).

@palemieux palemieux merged commit ecec1fa into master Nov 20, 2023
2 checks passed
@palemieux palemieux deleted the ngaullier-webvtt_align branch March 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants