Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for document filters #423

Merged
merged 11 commits into from
Dec 29, 2023
Merged

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Dec 17, 2023

tt convert -i <.scc file> -o <.ttml file> --itype SCC --otype TTML --filter lcd --config '{"general": {"progress_bar":false, "log_level":"WARN"}, "lcd": {"bg_color": "blue"}}'

Closes #417

Add document filter class

Started work

More progress

More progress

Making progress

Making progress

Making progress

First full run

Add color override and documentation
@palemieux palemieux marked this pull request as ready for review December 22, 2023 06:25
@ngaullier
Copy link
Contributor

README: double quote closing missing after "black on
Examples: "#FF0000" (red), "transparent", "black
I think you can just add a README entry for lcd/ "preserve_text_align" and everything looks very good to me! Thank you!
There is still a last late thing, I apologize I just get it now, it is the safe area : some users might want a different safe area on the height and on the width. My production shows 10% in width and 0% in height: I guess that on a smartphone, the screen height is so small (and with no overscan) that it is nice to have subtitles stick to the bottom, but on the other side, having the eyes moving hard left to hard right all the time must be annoying. I don't know if this opinion is shared or not, I just can tell you this is common practice for a (very) big content owner here; I don't know how people would react if having to change to an "isotropic" safe area.
I mean, you have done such a work, it does not seem reasonable to me to ask you even more! So up to you!

@palemieux
Copy link
Contributor Author

Thanks for the eagle eye on the readme. Should be fixed now.

Re: safe area, I think I need to better understand the use case to have an opinion -- happy to have a side discussion on the topic. At a high-level, I do not think safe area should be set to accommodate a specific set of devices. Device limitation/idiosyncrasies should be handled at the device by the player, with the understanding that some reasonable safe area exists. Makes sense?

In the meantime, I suggest we merge the PR as-is and iterate, if needed, before the next release.

@palemieux palemieux self-assigned this Dec 28, 2023
@ngaullier
Copy link
Contributor

ngaullier commented Dec 29, 2023

OK, that's fine. I mean merge and even release. I will wait strong confirmed needs before asking additionnal features.

@palemieux palemieux merged commit 96cf63c into master Dec 29, 2023
2 checks passed
@palemieux palemieux deleted the feature/implement-document-filters branch March 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STL reader: option to set a generic, basic style
2 participants