Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega/bridge: add tap mirror #1118

Merged
merged 4 commits into from
Jun 21, 2018
Merged

Conversation

jcrussell
Copy link
Contributor

Implement tap mirror to create a mirror of a tap. Seems to work and
not break a capture on the same interface.

Fixes #1114

Implement `tap mirror` to create a mirror of a tap. Seems to work and
not break a capture on the same interface.

Fixes sandia-minimega#1114
@jcrussell jcrussell added this to the 2.5 milestone Jun 12, 2018
Tweak tap mirror so that it mirrors between two existing taps. Uses some
sweet goto action.

Add article showing basic usage.
@jcrussell
Copy link
Contributor Author

Breaks minitests, patching incoming.

@jcrussell
Copy link
Contributor Author

TODO: clear tap mirror?

Now you can remove mirrors. Mirrors are now also cleared by `clear tap`.
Copy link
Contributor

@djfritz djfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djfritz djfritz merged commit ffa1746 into sandia-minimega:master Jun 21, 2018
@jcrussell jcrussell deleted the issue-1114 branch June 21, 2018 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants