Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimega/bridge: add `tap mirror` #1118

Merged
merged 4 commits into from Jun 21, 2018
Merged

Conversation

@jcrussell
Copy link
Contributor

@jcrussell jcrussell commented Jun 12, 2018

Implement tap mirror to create a mirror of a tap. Seems to work and
not break a capture on the same interface.

Fixes #1114

Implement `tap mirror` to create a mirror of a tap. Seems to work and
not break a capture on the same interface.

Fixes #1114
@jcrussell jcrussell added this to the 2.5 milestone Jun 12, 2018
jcrussell added 2 commits Jun 14, 2018
Tweak tap mirror so that it mirrors between two existing taps. Uses some
sweet goto action.

Add article showing basic usage.
s/Create/Delete.
@jcrussell
Copy link
Contributor Author

@jcrussell jcrussell commented Jun 14, 2018

Breaks minitests, patching incoming.

@jcrussell
Copy link
Contributor Author

@jcrussell jcrussell commented Jun 14, 2018

TODO: clear tap mirror?

Now you can remove mirrors. Mirrors are now also cleared by `clear tap`.
Copy link
Contributor

@djfritz djfritz left a comment

LGTM

@djfritz djfritz merged commit ffa1746 into sandia-minimega:master Jun 21, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcrussell jcrussell deleted the jcrussell:issue-1114 branch Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants